chore: use relative path in the comment for the baseURL#165
Merged
yury-s merged 2 commits intomicrosoft:mainfrom Sep 30, 2025
Merged
chore: use relative path in the comment for the baseURL#165yury-s merged 2 commits intomicrosoft:mainfrom
yury-s merged 2 commits intomicrosoft:mainfrom
Conversation
Othewise it may cause confusion if the user puts something like https://demo.playwright.dev/todomvc/#/ in the base url and wants to navigate to that exact url by default.
dgozman
approved these changes
Sep 30, 2025
assets/playwright.config.js
Outdated
| /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ | ||
| use: { | ||
| /* Base URL to use in actions like `await page.goto('/')`. */ | ||
| /* Base URL to use in actions like `await page.goto('./')`. */ |
Contributor
There was a problem hiding this comment.
Do you think empty string looks better?
Member
Author
There was a problem hiding this comment.
Yes, it does look better, but I'm worried that it makes it less clear how to write a relative url there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Othewise it may cause confusion if the user puts something like https://demo.playwright.dev/todomvc/#/ in the base url and wants to navigate to that exact url by default.